Fix memory leak in get_html_source (thanks @mreitinger for patch)#83
Merged
Fix memory leak in get_html_source (thanks @mreitinger for patch)#83
Conversation
It looks like $resource/$request never gets freed if $resource->get_data_finish($result); is called within the callback (even if this is correct according to the webkit docs).
Member
|
Looks good seems to be a better implementation to ensure the operation is completed. For reference the resource is this https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebResource.html |
jscarty
approved these changes
Oct 16, 2020
Member
jscarty
left a comment
jscarty
left a comment
There was a problem hiding this comment.
Looks good, sensible way to make sure the operation completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like $resource/$request never gets freed if
$resource->get_data_finish($result); is called within the callback
(even if this is correct according to the webkit docs).